Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report compile error when can't encode/decode RPC args/result #289

Closed
intellifactory-bb opened this issue Dec 6, 2014 · 5 comments
Closed
Labels

Comments

@intellifactory-bb
Copy link

Previously wrongly typed RPC arguments reported a warning, result haven't.


@intellifactory-bb
Copy link
Author

fix #289: give compile error on non-encodable type in RPC

→ <<cset 80c9da18ad31>>


Original comment by: András Jankó

@V0d01ey
Copy link

V0d01ey commented Jul 12, 2018

Now if an argument/result-class don't have a default constructor the analyzer don't report a warning.
Should I open a new issue? Or this issue can be reopened?

@Jand42
Copy link
Member

Jand42 commented Jul 13, 2018

@V0d01ey Not even compilation fails? I will check this. The C# analyzer is not doing the RPC signature verification right now as it needs reflection (possibly this will change if RPC/and sitelets json behavior are unified).

@V0d01ey
Copy link

V0d01ey commented Jul 15, 2018

@Jand42 , yes, the error reveals itself by crash only when you try to send such object (not null) from client to server. And inside complex structure it is not trivial to locate the problem.

@Jand42
Copy link
Member

Jand42 commented Jul 16, 2018

@V0d01ey Thanks for the report! I have created ticket #989.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants