Fix #220: in value Attrs, check equality during View propagation #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes, this is good, thanks! I wonder what performance benefit it also brings. Do you have any idea? |
|
FYI, @steiner2001 revived @evancz's TodoMVC benchmark and plugged in the 4.7/5.0-preview WebSharper versions and the latest React one. As expected, WebSharper.UI still performs ~5-10% better than React (which is amazing since we haven't touched the fundamentals in UI for years). We can gauge this PR soon against the WS4.7 numbers - https://steiner2001.github.io/react_vs_websharper_UI_Performance/ |
|
FYI - latest benchmark shows roughtly the same performance as before. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @cata
This should fix the cursor jump issue by checking for equality early in the View propagation.
I was also wondering whether we should remove the check before setting the Var here; but I think it's still useful to avoid doing multiple propagations because both
inputandkeypressare triggered.