Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update grpc-start: Call insecure gRPC services #17521

Merged
merged 2 commits into from
Apr 9, 2020
Merged

Update grpc-start: Call insecure gRPC services #17521

merged 2 commits into from
Apr 9, 2020

Conversation

HamidMolareza
Copy link
Contributor

Enable trust the HTTPS development certificate on some Linux distributions is not easy.
Adding this instructions can make it easier to develop on Linux.

Enable trust the HTTPS development certificate on some linux distributions is not easy. 
Adding this instructions can make it easier to develop on Linux.
@scottaddie scottaddie requested a review from JamesNK March 31, 2020 01:52
@JamesNK
Copy link
Member

JamesNK commented Mar 31, 2020

The added comment is about a similar problem to the comment above.

Did you find that the gRPC client failed even after trusting the development certificate?

@HamidMolareza
Copy link
Contributor Author

After trusting the development certificate, the client work fine.

This article is suitable for Windows users but not Linux users, especially beginner programmers who read this tutorial.

It also seems that ignoring certificate can be an easy way to develop (on Linux). But most of all, beginner programmer on Linux should be considered.

I put the comment at the bottom of the page for the following reasons:

  • Most likely Windows users don't get into trouble.
  • Those who cannot or do not enable the certificate correctly will have problems at the end of the text and after the client runs.
  • Trusting the development certificate can be good way and it should be in the main text, but this is a much easier and optional way.

This comment can also be combined with the previous comment for Linux users.

@scottaddie scottaddie merged commit f574f49 into dotnet:master Apr 9, 2020
@scottaddie
Copy link
Member

@HamidMolareza Thank you for your help with this.

@HamidMolareza HamidMolareza deleted the patch-1 branch April 9, 2020 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants