Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed HTTPS default binding #26082

Conversation

Daniel-Genkin-MS-2
Copy link
Contributor

I just merged a breaking change PR that removes the default HTTPS binding address from Kestel. Therefore, it does not automatically default to binding to https://localhost:5001 anymore. This PR updates the docs to be consistent.

My PR: dotnet/aspnetcore#42021
The breaking change announcement: aspnet/Announcements#486
The tracking issue: dotnet/aspnetcore#42016

@Daniel-Genkin-MS-2
Copy link
Contributor Author

Hmm, this is another repo for which I am not a contributor apparently. @Tratcher can you please add the necessary reviewers?

@Rick-Anderson
Copy link
Contributor

Rick-Anderson commented Jun 8, 2022

@Daniel-Genkin-MS-2 If you want to get credit for the PR merging, can you go to https://docs.microsoft.com/en-us/aspnet/core/fundamentals/servers/kestrel/endpoints
At the top right of the article, select the Edit pen icon:

image

Select the pen icon again. Save. Just change the date or append a space.

IF YOU DON'T CARE if YOU GET CREDIT

I'll create a new .NET 7 version of this file which is just a copy of the .NET 6 version. I'll merge that branch. I'll open a new PR with your changes here. That way the GitHub diff has only the changes you've made. That's how we do new versions. That way you get a really clean GitHub diff only with what you changed.

This PR doesn't show what has changed.

Does that make sense? Let me know how you'd like to proceed.

EDIT
I think the easiest way if you want credit and the GitHub history to reflect your work

  1. I'll create a V7 (identical to V6) and merge
  2. You create a PR and copy/paste you V7.

@Daniel-Genkin-MS-2
Copy link
Contributor Author

I did try to update the date and save but I don't have write access to the repo. Is it hard to get this access? If so it's ok if we just merge without crediting me.

@Rick-Anderson Rick-Anderson merged commit 34fae9d into dotnet:main Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants