-
Notifications
You must be signed in to change notification settings - Fork 25.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Routing features (loc changes, NavigationLock) #26919
Conversation
@Rick-Anderson ... I might need some SiteHelp™ on this one. Other PRs are building. I can't get a build report. I don't know if PR content is choking the build system or if the build system itself has something weird going on.
Strange to break where it did. The first commit where things went sideways is a trivial update ... |
@MackinnonBuck ... I think I have the disposal set up correctly now. ... well ... one more commit 👇 to remove the |
Co-authored-by: Mackinnon Buck <mackinnon.buck@gmail.com>
Ok ... getting there. I went with ...
UPDATE: mmmmmmmmmmmmm ... 🤔 ....... maybe not. That makes it sound like that's all you can do ... that preventing nav is the only way to handle nav here. Let me try again! brb UPDATE: I think ur right. I played with several heading options. I came around to your suggestion. It's on the next commit 👇. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Thanks, @MackinnonBuck! I'll get up with Rick on the failing build. It looks like a SiteHelp issue will need to be opened internally to find out what's wrong with this PR. Anyway ... I need to 🛌😴 on it for one night anyway and make final grammar/style changes. |
Lets give it a few hours. Build was down last week. If it's not building by tomorrow 4 AM, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We may also want to document the conclusion we recently reached in dotnet/aspnetcore#43725. The ConfirmExternalNavigation
parameter will do nothing if the user directly changes the URL in the address bar to an external site without interacting with the page first.
In an effort to get this merged, I'm going to try a fresh branch/PR. This all started happening on a trivial content commit, and other PRs are building just fine. I don't see any blown markdown. This PR just can't shake off its 😈 gremlins 😈. |
Moved to the 🎉 successfully building 🍻 #26947. |
Addresses #26364
Internal Review Topic (links to sections):
💥🚑🚒🚓
Ignore the doc build failure. We'll figure that out separately.
Notes
These are numbered to facilitate easy feedback responses.
NavigateTo
coverage.Router
level should probably be covered first, as it's broader, app-level behavior.BasicTestApp
examples but don't think we want to show something like these in general coverage. Devs can explore them (and try them locally) if they wish after following the links.ConfirmExternalNavigation
feature, what's better about usingNavigationLock
over just registering a handler and not using theNavigationLock
component?