-
Notifications
You must be signed in to change notification settings - Fork 25.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Server timeout and Keep Alive interval config #29297
Conversation
Ping @surayya-MS ... Just making sure that you saw this ... no rush. |
When creating a hub connection in a component, set the <xref:Microsoft.AspNetCore.SignalR.Client.HubConnection.ServerTimeout> (default: 30 seconds), <xref:Microsoft.AspNetCore.SignalR.Client.HubConnection.HandshakeTimeout> (default: 15 seconds), and <xref:Microsoft.AspNetCore.SignalR.Client.HubConnection.KeepAliveInterval> (default: 15 seconds) on the built <xref:Microsoft.AspNetCore.SignalR.Client.HubConnection>. The following example, based on the `Index` component in the [SignalR with Blazor tutorial](xref:blazor/tutorials/signalr-blazor), uses default values: | ||
:::moniker range=">= aspnetcore-8.0" | ||
|
||
When creating a hub connection in a component, set the <xref:Microsoft.AspNetCore.SignalR.Client.HubConnection.ServerTimeout> (default: 30 seconds) and <xref:Microsoft.AspNetCore.SignalR.Client.HubConnection.KeepAliveInterval> (default: 15 seconds) on the <xref:Microsoft.AspNetCore.SignalR.Client.HubConnectionBuilder>. Set the <xref:Microsoft.AspNetCore.SignalR.Client.HubConnection.HandshakeTimeout> (default: 15 seconds) on the built <xref:Microsoft.AspNetCore.SignalR.Client.HubConnection>. The following example, based on the `Index` component in the [SignalR with Blazor tutorial](xref:blazor/tutorials/signalr-blazor), shows the assignment of default values: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@javiercn , was it this chat tutorial that we wanted to delete from docs?
@surayya-MS ... I was working through the changes, and I need to double-check this one ...
... because if we do that it isn't just this section. The workaround is also part of the Global deployment and connection failures section, and it's going to get chopped for that coverage prior to 8.0, too. We'll be telling devs for <8.0 that they need to change it, but they can't because we don't support the workaround. Also note that I don't follow the opening paragraph instructions ("rephrase"/"replace" but "keep") ... Do you mean that in the text only the names should change for 8.0 or later? ... and "actually are" implies that the current text is incorrect, but I think this was all reviewed by Javier (in ancient Blazor history 👴😆). If the changes are complex, it might be best if you make GH suggestions for the exact line line updates. UPDATE: I'll make the obvious changes on my next commit ...... Done! |
@guardrex sorry I previously missed the <8.0 part. I assumed that this is for aspnetcore-8.0. You are right we shouldn't remove it then.
I meant let's replace descriptions for I'll write a follow up comment for that Update: No follow up comments. Looks good to me! |
Note that the last commit is just a tiny NIT ... I'm merely hyphenating "Keep-Alive" for consistency. That's all that's on the commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
I didn't change the first part tho ... the list of two API items ( |
Oh! I see ........
Gotcha! Ok, good to merge then! 🎉 |
... but I'll circle around later if you/Javier intend to pull the Blazor-SignalR tutorial from the doc set per #29297 (comment). |
No need to change the paragraph because of the workaround example for > 8.0. The descriptions for |
Yes ... but we might want to organize this a bit differently. Perhaps, I should move that API down into the < 8.0 block and have a different version of it that only explains Let me put that on a commit and you can see how it composes that way. Stand-by .................................. |
The last commit ...
|
LGTM! |
Fixes #29296
Surayya ...
Internal previews