Apply a CSP in non-Development environments #31106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MackinnonBuck
approved these changes
Nov 28, 2023
Comment on lines
319
to
320
| * Apply the CSP via the `App` component, which applies the CSP to all layouts of the app. | ||
| * Apply the CSP to the app's layout files using the [`<HeadContent>` tag](xref:blazor/components/control-head-content). For complete effectiveness, every app layout file must adopt the approach. |
There was a problem hiding this comment.
Is the idea here that approach 1 should be preferred, when possible? The only reason I can think to use approach 2 is if you have a WebAssembly standalone app with a static index.html file whose content can't be determined programmatically.
There was a problem hiding this comment.
Perhaps, custom combos of external scripts (i.e., different CSPs) should be permitted on a per-layout basis. I felt that since it's a valid approach and might be useful that we should list it ... as you suggest tho, not in the first position.
UPDATE: I fleshed it out on the next commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #31105
Mackinnon ...
<head>content. I add a new section (just picking up with 8.0+, I won't sweat prior releases) that will assist devs with this problem.If you want to see all of the Development errors that hit when a CSP is just dropped in and the app is run in the Development environment, they're in the opening comment of the issue at ...
#31105
Internal previews