-
Notifications
You must be signed in to change notification settings - Fork 25.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve AdditionalAssemblies coverage #31131
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me.
@MackinnonBuck ... Your explanation unlocked a couple of concepts. Your text might be further organized by static versus interactive routing. I'm feel'in that I might still have a 😈 or two, but see if what's on the PR now breaks it down clearly for readers. Also, I think it is good to leave the static/interactive discussion here in this section. These concepts are a bit complicated. However, I'd still like to add something general on the static/interactive routing concepts near the top of the article. I'm going to try and do that now. |
@MackinnonBuck ... I added content at the top of the article on static/interactive routing to at least get the ball rolling on review. I probably don't have it exactly right, but you can see what I think readers (and a silly 🦖) will need to understand. I took my BWA test app (global Interactive Auto rendering applied, UPDATE: The latest commit calls this section out in the Migration guidance. |
Co-authored-by: Mackinnon Buck <mackinnon.buck@gmail.com>
Fixes #31081
Addresses #28161
We'll need coverage on static versus interactive routers.
Internal previews