Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve AdditionalAssemblies coverage #31131

Merged
merged 16 commits into from
Dec 1, 2023
Merged

Improve AdditionalAssemblies coverage #31131

merged 16 commits into from
Dec 1, 2023

Conversation

guardrex
Copy link
Collaborator

@guardrex guardrex commented Nov 27, 2023

Copy link
Member

@danroth27 danroth27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

aspnetcore/blazor/fundamentals/routing.md Outdated Show resolved Hide resolved
@guardrex
Copy link
Collaborator Author

@MackinnonBuck ... Your explanation unlocked a couple of concepts. Your text might be further organized by static versus interactive routing. I'm feel'in that I might still have a 😈 or two, but see if what's on the PR now breaks it down clearly for readers.

Also, I think it is good to leave the static/interactive discussion here in this section. These concepts are a bit complicated. However, I'd still like to add something general on the static/interactive routing concepts near the top of the article. I'm going to try and do that now.

@guardrex
Copy link
Collaborator Author

guardrex commented Nov 28, 2023

@MackinnonBuck ... I added content at the top of the article on static/interactive routing to at least get the ball rolling on review. I probably don't have it exactly right, but you can see what I think readers (and a silly 🦖) will need to understand.

I took my BWA test app (global Interactive Auto rendering applied, Routes component in the .Client project), and I dropped an Interactive Server component into the server project. Indeed!!! When I navigated to the test component, it briefly appeared in the UI under static routing before landing on a 404 when interactive client-side routing took over.

UPDATE: The latest commit calls this section out in the Migration guidance.

aspnetcore/blazor/components/render-modes.md Outdated Show resolved Hide resolved
aspnetcore/blazor/fundamentals/routing.md Outdated Show resolved Hide resolved
aspnetcore/blazor/fundamentals/routing.md Outdated Show resolved Hide resolved
aspnetcore/blazor/fundamentals/routing.md Outdated Show resolved Hide resolved
aspnetcore/blazor/fundamentals/routing.md Show resolved Hide resolved
guardrex and others added 2 commits November 29, 2023 06:21
Co-authored-by: Mackinnon Buck <mackinnon.buck@gmail.com>
@guardrex guardrex merged commit 050c281 into main Dec 1, 2023
3 checks passed
@guardrex guardrex deleted the guardrex-patch-4 branch December 1, 2023 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve AdditionalAssemblies coverage
3 participants