Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add WebAssembly (runtime) startup callbacks #31852

Merged
merged 5 commits into from
Feb 16, 2024
Merged

Add WebAssembly (runtime) startup callbacks #31852

merged 5 commits into from
Feb 16, 2024

Conversation

guardrex
Copy link
Collaborator

@guardrex guardrex commented Feb 16, 2024 •
edited by github-actions bot
Loading

Fixes #31811

Marek ...

  • Along with correcting any mistakes that a 🦖 made 🙈😄, is there any additional info that should appear?
  • Was the bit of text you stated for onRuntimeReady ... "and passed in the .NET runtime API" ... important to keep? I 🔪 it, but I'll add it back if it's important to call that out.
  • Is the sample code that you cross-linked OK to show here with these?
  • Are there any gotchas 😈 that devs should be aware of?

Internal previews

📄 File 🔗 Preview link
aspnetcore/blazor/fundamentals/startup.md ASP.NET Core Blazor startup

@guardrex guardrex mentioned this pull request Feb 16, 2024
Closed
@guardrex guardrex requested a review from maraf February 16, 2024 14:24
@guardrex guardrex self-assigned this Feb 16, 2024
maraf
maraf reviewed Feb 16, 2024
View reviewed changes
Copy link
Member

@maraf maraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you! I have a few suggestions

  • Better samples then those in the unit test
  • Link to the parameter type definition for the second callback
  • Note about return type

aspnetcore/blazor/fundamentals/startup.md Outdated Show resolved Hide resolved
aspnetcore/blazor/fundamentals/startup.md Outdated Show resolved Hide resolved
aspnetcore/blazor/fundamentals/startup.md Show resolved Hide resolved
aspnetcore/blazor/fundamentals/startup.md Outdated Show resolved Hide resolved
guardrex and others added 3 commits February 16, 2024 12:49
@guardrex @maraf
Apply suggestions from code review
a2fa6a7 
Co-authored-by: Marek Fišera <mara@neptuo.com>
@guardrex
Update
4cea4de
@guardrex
Update
7ae083c
@guardrex guardrex merged commit 39e8777 into main Feb 16, 2024
3 checks passed
@guardrex guardrex deleted the guardrex-patch-3 branch February 16, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maraf maraf maraf approved these changes

Assignees

@guardrex guardrex

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consider documenting additional WebAssembly (runtime) startup callbacks
2 participants
@guardrex @maraf