Remove netcoreapp2.0;net461 from TFMs for IntegrationTests.ManualRunn…

…ing.MultipleFrameworks
dotnet · Nov 26, 2023 · 2e62b9b · 2e62b9b
1 parent 0583cb9
commit 2e62b9b
Showing 1 changed file with 10 additions and 2 deletions.
diff --git a/...ltipleFrameworks/BenchmarkDotNet.IntegrationTests.ManualRunning.MultipleFrameworks.csproj b/...ltipleFrameworks/BenchmarkDotNet.IntegrationTests.ManualRunning.MultipleFrameworks.csproj
@@ -4,8 +4,16 @@
     <AssemblyTitle>BenchmarkDotNet.IntegrationTests.ManualRunning.MultipleFrameworks</AssemblyTitle>
     <!-- We test the oldest frameworks supported by BDN (net461 and netcoreapp2.0), as well as newer versions of those frameworks. -->
     <TreatWarningsAsErrors>false</TreatWarningsAsErrors>
-    <TargetFrameworks>net461;net48;netcoreapp2.0;net8.0</TargetFrameworks>
-    <NoWarn>$(NoWarn);NU1903</NoWarn> <!-- NU1903: Package 'Microsoft.NETCore.App' 2.0.0 has a known high severity vulnerability -->
+    <!-- Using netcoreapp2.0 and net461 as one of the target frameworks leads to the following problems:-->
+    <!-- * NU1903: Package 'Microsoft.NETCore.App' 2.0.0 has a known high severity vulnerability -->
+    <!-- * Incompability with xunit.runner.visualstudio 2.4.2+ -->
+    <!-- Therefore, we don't use it explicitly in the source code base to avoid persistent warnings -->
+    <!-- If you need it for local backward compatibility experiments, do the following: -->
+    <!-- 1. Add 'netcoreapp2.0;net461' in the list of TargetFrameworks -->
+    <!-- 2. Add '<NoWarn>$(NoWarn);NU1903</NoWarn>' -->
+    <!-- 3. Downgrade the xunit.runner.visualstudio NuGet package to v2.4.1 -->
+    <!-- Please, do not commit these changes to the repository -->
+    <TargetFrameworks>net462;net48;net8.0</TargetFrameworks>
     <AllowUnsafeBlocks>true</AllowUnsafeBlocks>
     <AssemblyName>BenchmarkDotNet.IntegrationTests.ManualRunning.MultipleFrameworks</AssemblyName>
     <PackageId>BenchmarkDotNet.IntegrationTests.ManualRunning.MultipleFrameworks</PackageId>