Restrict MemoryDiagnoserAttribute usage to class (#1122), fixes #1119

* Restrict MemoryDiagnoserAttribute usage to class * Restricted rest of unrestricted attributes
dotnet · Mar 31, 2019 · e1d4d2f · e1d4d2f
1 parent 1c1913a
commit e1d4d2f
Show file tree

Hide file tree

Showing 6 changed files with 8 additions and 1 deletion.
diff --git a/src/BenchmarkDotNet/Attributes/ArtifactsPathAttribute.cs b/src/BenchmarkDotNet/Attributes/ArtifactsPathAttribute.cs
@@ -5,6 +5,7 @@
 namespace BenchmarkDotNet.Attributes
 {
     [PublicAPI]
+    [AttributeUsage(AttributeTargets.Class)]
     public class ArtifactsPathAttribute : Attribute, IConfigSource
     {
         public string Value { get; }

diff --git a/src/BenchmarkDotNet/Attributes/DisassemblyDiagnoserAttribute.cs b/src/BenchmarkDotNet/Attributes/DisassemblyDiagnoserAttribute.cs
@@ -4,6 +4,7 @@
 
 namespace BenchmarkDotNet.Attributes
 {
+    [AttributeUsage(AttributeTargets.Class)]
     public class DisassemblyDiagnoserAttribute : Attribute, IConfigSource
     {
         /// <param name="printIL">IL will be printed. False by default.</param>

diff --git a/src/BenchmarkDotNet/Attributes/GroupBenchmarksByAttribute.cs b/src/BenchmarkDotNet/Attributes/GroupBenchmarksByAttribute.cs
@@ -5,6 +5,7 @@
 namespace BenchmarkDotNet.Attributes
 {
     [PublicAPI]
+    [AttributeUsage(AttributeTargets.Class)]
     public class GroupBenchmarksByAttribute: Attribute, IConfigSource
     {
         public IConfig Config { get; }

diff --git a/src/BenchmarkDotNet/Attributes/KeepBenchmarkFilesAttribute.cs b/src/BenchmarkDotNet/Attributes/KeepBenchmarkFilesAttribute.cs
@@ -8,6 +8,7 @@ namespace BenchmarkDotNet.Attributes
     /// determines if all auto-generated files should be kept or removed after running the benchmarks
     /// </summary>
     [PublicAPI]
+    [AttributeUsage(AttributeTargets.Class)]
     public class KeepBenchmarkFilesAttribute : Attribute, IConfigSource
     {
         public IConfig Config { get; }

diff --git a/src/BenchmarkDotNet/Attributes/MemoryDiagnoserAttribute.cs b/src/BenchmarkDotNet/Attributes/MemoryDiagnoserAttribute.cs
@@ -4,6 +4,7 @@
 
 namespace BenchmarkDotNet.Attributes
 {
+    [AttributeUsage(AttributeTargets.Class)]
     public class MemoryDiagnoserAttribute : Attribute, IConfigSource
     {
         public IConfig Config { get; }

diff --git a/src/BenchmarkDotNet/Attributes/StopOnFirstErrorAttribute.cs b/src/BenchmarkDotNet/Attributes/StopOnFirstErrorAttribute.cs
@@ -2,11 +2,13 @@
 using BenchmarkDotNet.Configs;
 using JetBrains.Annotations;
 
-namespace BenchmarkDotNet.Attributes {
+namespace BenchmarkDotNet.Attributes 
+{
     /// <summary>
     /// determines if running should be stop after first error
     /// </summary>
     [PublicAPI]
+    [AttributeUsage(AttributeTargets.Class)]
     public class StopOnFirstErrorAttribute : Attribute, IConfigSource
     {
         public IConfig Config { get; }