You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
How hard would it be for BDN to consume and do reasonable things with tests that contain xunit-performance attributes? That way we could still author perf tests like we do now but run them under either perf harness.
It should not be hard. In fact, the implementation of BenchmarkRunner.Run is pretty simple:
BenchmarkConverter just takes method attributes and transform it to BenchmarkRunInfo which contains information about how to run the benchmarks without any knowledge about original attributes (see source code: https://github.com/dotnet/BenchmarkDotNet/blob/v0.10.12/src/BenchmarkDotNet.Core/Running/BenchmarkConverter.cs)
It's pretty easy to make it pluggable and write XunitPerformanceBenchmarkConverter which transforms xunit-performance attributes to the BenchmarkDotNet represtnation.
I like this idea because it will allow to run all existed xunit benchmarks on BenchmarkDotNet without massive modifications of the source code.
The text was updated successfully, but these errors were encountered:
The original idea by @AndyAyersMS:
It should not be hard. In fact, the implementation of
BenchmarkRunner.Run
is pretty simple:BenchmarkConverter
just takes method attributes and transform it toBenchmarkRunInfo
which contains information about how to run the benchmarks without any knowledge about original attributes (see source code:https://github.com/dotnet/BenchmarkDotNet/blob/v0.10.12/src/BenchmarkDotNet.Core/Running/BenchmarkConverter.cs)
It's pretty easy to make it pluggable and write
XunitPerformanceBenchmarkConverter
which transformsxunit-performance
attributes to the BenchmarkDotNet represtnation.I like this idea because it will allow to run all existed xunit benchmarks on BenchmarkDotNet without massive modifications of the source code.
The text was updated successfully, but these errors were encountered: