Introduce BenchmarkDotNet.Annotations #678
Comments
|
@adamsitnik, what do you think about this idea? |
|
I really like this idea! It looks like it's a must-have for some scenarios like "I have this piece of IL, please just run it for framework X". |
|
@AndreyAkinshin can I take this issue? it's blocking me moreover, I have an additional idea: maybe we keep all the types from |
Sure. |
|
@adamsitnik, I think, it makes sense to release it in v0.11.x because it contains some breaking changes (with a few other things which also contain breaking changes; I will create corresponding changes soon). |
Yes, it's a very good idea, I like it! |
|
Is this available on a preview feed somewhere, by chance? Now that I am able to code again (😄) I was looking into creating a .NET Standard library with Benchmark.NET-specific classes. For instance, a strongly-typed wrapper around |
|
@Mike-EEE our preview package targets .NET Standard 2.0, you can get if from: <packageSources>
<add key="bdn-nightly" value="https://ci.appveyor.com/nuget/benchmarkdotnet" />
</packageSources> |
|
Beautimous. Thank you, @adamsitnik. 👍 |
|
@adamsitnik Can I help with this issue or is it already done? |
|
It's partially done - I have ported BDN to .NET Standard 2.0. Before you would start moving the attributes and configs to new library I need to finish #912 first. But I won't have time for it in the next 10 days, so I would say that this issue is currently blocked. |
|
Do you have idea what task can I do before?
…On Fri, Oct 19, 2018, 15:33 Adam Sitnik ***@***.***> wrote:
It's partially done - I have ported BDN to .NET Standard 2.0.
Before you would start moving the attributes and configs to new library I
need to finish #912 <#912>
first. But I won't have time for it in the next 10 days, so I would say
that this issue is currently blocked.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#678 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AQh-j37QlyXeweGP56v3KSgp0BMAJk-pks5umdSrgaJpZM4SlEVd>
.
|
|
@wojtpl2 if you would like to implement one of the following features it would be awesome #544 - "Diff view for disassembler output" - as of today our disassembler produces a very nice github markdown output #560 (comment) it would be great if you could implement a diff of two assembly listings with an export to GitHub markdown (it has a special "```diff" option) used commonly in CoreCLR by JIT Team members |
|
Can you assign me to #544 and #687? I will try to do this next week.
#553 it is interesting but I can try to do this later. I think this issue
can take more time.
Of course I would like to do this issue #678 when it's possible. I'm good
at this kind of refactoring.
…On Fri, Oct 19, 2018, 16:43 Adam Sitnik ***@***.***> wrote:
@wojtpl2 <https://github.com/wojtpl2> if you would like to implement one
of the following features it would be awesome
#544 <#544> - "Diff view
for disassembler output" - as of today our disassembler produces a very
nice github markdown output #560 (comment)
<#560 (comment)>
it would be great if you could implement a diff of two assembly listings
with an export to GitHub markdown (it has a special "```diff" option) used
commonly in CoreCLR by JIT Team members
#553 <#553> - "New BDN
run mode that causes cache misses between iterations" - it would require to
add new flag to our Job info and extend the Engine with possibility to
clean the cache between iterations
#687 <#687> - "Implement
[Arguments] support for InProcessToolchain" we have two kind of toolchains:
the ones that generate and compile C# and the ones that do it with IL.
Changing the IL generation is non-trivial, when I implemented [Arguments]
support I have updated our C# template file which was easy, but not the
code which generates IL.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#678 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AQh-j6vMkEY-5sPojoWvtu832Wl2PcS1ks5umeUHgaJpZM4SlEVd>
.
|
|
@wojtpl2 it looks like @ig-sinicyn is going to solve #687 with #919 @wojtpl2 we are going to assign you to #544 |
|
We have introduced the Annotations quite a while ago, I am closing the issue. |
We should move all API which includes attributes and configs to a separate NuGet package
BenchmarkDotNet.Annotations.Benefits:
BenchmarkRunner.Run), but also via command line (likedotnet benchmark, see Add a "benchmark" cmd to dotnet #213)The text was updated successfully, but these errors were encountered: