Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PackageReference for System.Management to latest (5.0.0). #1805

Merged
merged 1 commit into from
Sep 13, 2021

Conversation

mawosoft
Copy link
Contributor

  • Also updated Microsoft.Win32.Registry to latest (5.0.0) since it is a direct dependency of the former.
  • Fixes bugs in .Net Core >=3.1 builds in RuntimeInformation.GetAntivirusProducts() and GetVirtualMachineHypervisor() where the use of ManagementObjectSearcher throws a silently eaten exception.

Theoretically, this would also have affected MosCpuInfoProvider.MosCpuInfo, but its use is limited to .Net Framework by the caller.

You can easily see this in previous CI logs where the net461 build shows VM=Hyper-V in the system info while the net5.0 build doesn't.

- Also updated Microsoft.Win32.Registry to latest (5.0.0) since it is a direct dependency of the former.
- Fixes bugs in .Net Core >=3.1 builds in RuntimeInformation.GetAntivirusProducts() and GetVirtualMachineHypervisor() where the use of ManagementObjectSearcher throws a silently eaten exception.
mawosoft added a commit to mawosoft/BenchmarkDotNet that referenced this pull request Sep 12, 2021
This is an alternate to PR dotnet#1805 to see if updating all package references passes the CI checks.
Copy link
Member

@adamsitnik adamsitnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @mawosoft !

@adamsitnik adamsitnik merged commit 38b99b9 into dotnet:master Sep 13, 2021
@mawosoft mawosoft deleted the update-pkgref-sysmgmt branch September 13, 2021 11:13
@AndreyAkinshin AndreyAkinshin added this to the v0.13.2 milestone Sep 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants