Implement WakeLock so that the system does not enter sleep #2670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timcassell
reviewed
Nov 24, 2024
timcassell
reviewed
Nov 24, 2024
leonvandermeer
force-pushed
the
feature/wake-lock
branch
from
e3eb631 to
242589b
Compare
timcassell
reviewed
Dec 2, 2024
timcassell
reviewed
Dec 2, 2024
timcassell
reviewed
Dec 2, 2024
timcassell
reviewed
Dec 2, 2024
leonvandermeer
force-pushed
the
feature/wake-lock
branch
from
242589b to
d774258
Compare
timcassell
approved these changes
Dec 2, 2024
There was a problem hiding this comment.
LGTM! I would like a second review before merging this new functionality, though. @adamsitnik or @AndreyAkinshin may have different opinions on what the default should be.
…hmarks are running
Co-authored-by: Tim Cassell <35501420+timcassell@users.noreply.github.com>
leonvandermeer
force-pushed
the
feature/wake-lock
branch
from
d774258 to
75b75c9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement WakeLock so that the system does not enter sleep while benchmarks are running.
As a happy user of BDN, I was annoyed by the fact that long running benchmarks were not completed when I returned to my system. All because my system enters sleep, after not being touched for a while.
The test code needs to enumerate power requests. I decided not to pinvoke undocumented api as maintenance is difficult if it changes in future windows version. It gave me a chance to learn more about parsers in general 😂. Imo, maintaining the parser when
powercfg /requestsoutput would change is less difficult.In case you prefer usage of Superpower library to parse, I'm willing to change that.
All test code is in integration tests, since
powercfgneeds elevation. I imagine developers dislike failing unit tests when they run those locally.