Possible for --with-attribute to allow for multiple = in args?

[kkukshtel]

Hello! Trying to annotate some output functions with an additional attribute, specifically:
UnmanagedCallersOnly(CallConvs = new[] { typeof(CallConvCdecl) })
or something similar.

However, no matter what I try to pass to --with-attribute this either doesn't work because the program expects a key/value(?) or it generates the proper bindings but there is no attribute output. I also looked into the TerraFX interop rsp examples where you bind to Flags but I'm still unclear on what that's doing/why attributes need a key/value configuration when I assume they should just be copy-pasted strings, as well as what the key/value would be in my case.

[kkukshtel]

Right after typing this I figured out that the key is meant to be what you are binding the attribute to, and the value is the actual attribute. However I'm still running into issues because I have the constructor for the attribute that needs to be passed in for the array. I think it's a parsing issue re this:

ClangSharp/sources/ClangSharpPInvokeGenerator/Program.cs

Line 857 in 32bbe8a

if (parts.Length != 2)

Other ways to get around it could be positional params, but the ctor for the attribute has no params so you have to do a field assignment inline.

I understand why you want to bail on more than 2 =, maybe you (or I) could add something like --with-attribute-raw that allows for just grabbing whatever is after the first equals?

[tannergooding]

I'm fine with a contribution that changes this to split on the first = rather than only require one =

[kkukshtel]

Sounds great, made a PR here:

#471

[tannergooding]

Resolved with #471