Fix nested type names for properties #584
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When ClangSharp generates the type name for a property, if the type of the property is a nested type, then it walks from the parent of the current type to the root type and appends the names as it goes. This means that if the nesting is more than one type deep, then the types will be backwards.
For example, given:
ClangSharp generates:
So the type used when pinning the field is correct, but the type for the property itself is incorrect.
The fix is to prepend each type during the walk, then prepend the
ref
keyword as required.I also switched the code to use a
StringBuilder
.