Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore the NoInline attribute #585

Merged
merged 1 commit into from
Dec 16, 2024
Merged

Conversation

dpaoliello
Copy link
Contributor

The C++ NoInline attribute doesn't map to anything meaningful for C# or P/Invoke, so it can safely be ignored.

@tannergooding
Copy link
Member

The C++ NoInline attribute doesn't map to anything meaningful for C# or P/Invoke, so it can safely be ignored.

A small nit is that it might be relevant for non P/Invoke methods to bind as [MethodImpl(MethodImplOptions.NoInlining)], but that's relatively uncommon.

@tannergooding tannergooding merged commit 2d4e661 into dotnet:main Dec 16, 2024
13 checks passed
@dpaoliello dpaoliello deleted the noinline branch December 16, 2024 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants