Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conflicting return types in sample code #1574

Closed
zturchan opened this issue Jul 12, 2019 — with docs.microsoft.com · 2 comments · Fixed by #2813
Closed

Conflicting return types in sample code #1574

zturchan opened this issue Jul 12, 2019 — with docs.microsoft.com · 2 comments · Fixed by #2813
Assignees
Labels
area-migrations closed-fixed good first issue This issue should be relatively straightforward to fix.
Milestone

Comments

Copy link

This example code:

static MigrationBuilder CreateUser(
this MigrationBuilder migrationBuilder,
string name,
string password)
=> migrationBuilder.Sql($"CREATE USER {name} WITH PASSWORD '{password}';");

Does not appear to work, as migrationBuilder.Sql returns an OperationBuilder, which appears to be incompatible with the MigrationBuilder return type.


Document Details

Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

@ajcvickers ajcvickers added this to the Backlog milestone Sep 2, 2019
@ajcvickers ajcvickers modified the milestones: Backlog, 3.1.0 Sep 6, 2019
@bricelam bricelam added the good first issue This issue should be relatively straightforward to fix. label Jan 15, 2020
@ajcvickers
Copy link
Member

@bricelam Did we miss triaging this issue this morning? Is 3.1 correct?

@bricelam
Copy link
Contributor

3.1 is fine. It's a very small change

@ajcvickers ajcvickers modified the milestones: 3.1.0, 5.0.0 Mar 19, 2020
bricelam added a commit to bricelam/EntityFramework.Docs that referenced this issue Oct 27, 2020
Additional changes:

- Add tips about EXEC (fixes dotnet#2561)
- Add a tab for Get-Migration
- Update custom operation samples (fixes dotnet#1574)
- Fix some bad PMC examples (fixes dotnet#2296)
- Add examples using Name= (fixes dotnet#2145)

Fixes dotnet#1050
bricelam added a commit to bricelam/EntityFramework.Docs that referenced this issue Oct 27, 2020
Additional changes:

- Add tips about EXEC (fixes dotnet#2561)
- Add a tab for Get-Migration
- Update custom operation samples (fixes dotnet#1574)
- Fix some bad PMC examples (fixes dotnet#2296)
- Add examples using Name= (fixes dotnet#2145)

Fixes dotnet#1050
bricelam added a commit to bricelam/EntityFramework.Docs that referenced this issue Oct 28, 2020
Additional changes:

- Add tips about EXEC (fixes dotnet#2561)
- Add a tab for Get-Migration
- Update custom operation samples (fixes dotnet#1574)
- Fix some bad PMC examples (fixes dotnet#2296)
- Add examples using Name= (fixes dotnet#2145)

Fixes dotnet#1050
bricelam added a commit to bricelam/EntityFramework.Docs that referenced this issue Oct 28, 2020
Additional changes:

- Add tips about EXEC (fixes dotnet#2561)
- Add a tab for Get-Migration
- Update custom operation samples (fixes dotnet#1574)
- Fix some bad PMC examples (fixes dotnet#2296)
- Add examples using Name= (fixes dotnet#2145)
- Mention ExcludeFromMigrations (fixes dotnet#750)

Fixes dotnet#1050
bricelam added a commit to bricelam/EntityFramework.Docs that referenced this issue Oct 28, 2020
Additional changes:

- Add tips about EXEC (fixes dotnet#2561)
- Add a tab for Get-Migration
- Update custom operation samples (fixes dotnet#1574)
- Fix some bad PMC examples (fixes dotnet#2296)
- Add examples using Name= (fixes dotnet#2145)
- Mention ExcludeFromMigrations (fixes dotnet#750)
- Rearrange connection strings page

Fixes dotnet#1050
bricelam added a commit to bricelam/EntityFramework.Docs that referenced this issue Oct 29, 2020
Additional changes:

- Add tips about EXEC (fixes dotnet#2561)
- Add a tab for Get-Migration
- Update custom operation samples (fixes dotnet#1574)
- Fix some bad PMC examples (fixes dotnet#2296)
- Add examples using Name= (fixes dotnet#2145)
- Mention ExcludeFromMigrations (fixes dotnet#750)
- Rearrange connection strings page
- Use OutputDir instead of Namespace

Fixes dotnet#1050
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-migrations closed-fixed good first issue This issue should be relatively straightforward to fix.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants