Guidance on testing EF Core apps #2216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ErikEJ
reviewed
Mar 24, 2020
ajcvickers
force-pushed
the
NoTwoApplesAreTheSame0323
branch
from
6bc4d21
to
95e82df
Compare
| So if you do use SQLite for some testing, make sure to also test against your real database system. | ||
|
|
||
| See [Testing with SQLite](xref:core/miscellaneous/testing/sqlite) for EF Core specific guidance. | ||
|
|
There was a problem hiding this comment.
Most developers use in-memory instead of relational for perf reasons, so we should gives some tips how to speed it up. Assuming most of the time is spent creating the database/schema:
- Write tests that don't change the database or are wrapped in a transaction that is rolled back after the test is finished.
- Clean the database data instead of recreating the schema. See SqlServerDatabaseCleaner.cs for a generic way of how to do this.
- Create multiple copies of the database and assign one per test class to be able to run the tests in parallel
There was a problem hiding this comment.
Agreed. I have been sample tests and had similar thoughts. I think I'll create a new document for this to go alongside the updated docs for SQLite and in-memory.
There was a problem hiding this comment.
Will do this in another PR.
|
|
||
| Instead we use the in-memory database when unit testing something that uses DbContext. | ||
| In this case using the in-memory database is appropriate because the test is not dependent on database behavior. | ||
| Just don't do this to test actual database queries or updates. |
There was a problem hiding this comment.
Ambiguous what "this" is referring to. In general this sentence is low value
There was a problem hiding this comment.
Will re-word or remove in next PR.
AndriySvyryd
approved these changes
Mar 24, 2020
Co-Authored-By: Andriy Svyryd <AndriySvyryd@users.noreply.github.com>
Co-Authored-By: Andriy Svyryd <AndriySvyryd@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1304 and #430