Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reference 5.0.0-preview4 in samples #2399

Merged
merged 1 commit into from
May 20, 2020
Merged

Reference 5.0.0-preview4 in samples #2399

merged 1 commit into from
May 20, 2020

Conversation

roji
Copy link
Member

@roji roji commented May 20, 2020

No description provided.

@smitpatel
Copy link
Member

It would be easier if we just update all this on RTM (unless we know that we changed the API which would impact the sample.)

@ajcvickers
Copy link
Member

@smitpatel We have docs waiting to merge that need preview 4.

@smitpatel
Copy link
Member

@ajcvickers - Each doc sample which requires at least certain preview version can and should update to that particular preview version. e.g. if many to many gets implemented in preview6 then PR which adds documentation about it and sample for it can reference preview6 version in the sample.

@ajcvickers
Copy link
Member

I would rather if the sample needs a preview that it be the latest preview where possible.

@smitpatel
Copy link
Member

To me that is unnecessary overhead for seemingly no gain.

@roji
Copy link
Member Author

roji commented May 20, 2020

Note I only updated samples which were already on preview2 - it's more to make sure people who get previews get the last version. I agree there's not a huge value there but it's also very easy to do (plus I volunteer to do it)...

@roji roji merged commit c0d23b5 into master May 20, 2020
@smitpatel smitpatel deleted the SamplesPreview4 branch May 20, 2020 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants