Added check to prevent caching of the S4U tickets #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Godlike 💕 I'm not very deep in the topic, but isn't it possible to cache S4U tickets? |
|
It requires a significant overhaul of the cache mechanism, which isn't necessarily a bad idea, but it's quite a bit of work. Most other libraries actually don't cache S4U either. |
|
Thanks for the fast fix. I can confirm that it works now as intended. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem?
S4U is incorrectly caching and using S4U'ed tickets, meaning the wrong ticket can get selected.
What's the solution?
Don't cache or check the cache for S4U tickets.
What issue is this related to, if any?
Fixed #248