Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DIBuilder functions for OOP style #125

Merged
merged 4 commits into from
Dec 16, 2019
Merged

Conversation

yowl
Copy link
Contributor

@yowl yowl commented Dec 4, 2019

This change adds a few of the DIBuilder functions. First PR here so comments welcome. WIP as not finished but have a question.

Fixes #124

@msftclas
Copy link

msftclas commented Dec 4, 2019

CLA assistant check
All CLA requirements met.

@yowl yowl changed the title WIP: Add DIBuilder functions for OOP style Add DIBuilder functions for OOP style Dec 4, 2019
Copy link
Member

@tannergooding tannergooding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@tannergooding tannergooding merged commit 729d58e into dotnet:master Dec 16, 2019
@yowl yowl deleted the dibuilder branch December 16, 2019 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Question: Migrating to OOP - DIBuilder
3 participants