Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix AL ReopenDevices extension #1824

Merged
merged 2 commits into from
Dec 5, 2023
Merged

Fix AL ReopenDevices extension #1824

merged 2 commits into from
Dec 5, 2023

Conversation

okaniku
Copy link
Contributor

@okaniku okaniku commented Dec 5, 2023

Summary of the PR

Fixes the AL ReopenDevices extension to derive from ContextExtensionBase since it is a context extension.

Related issues, Discord discussions, or proposals

Issue

@okaniku okaniku requested a review from a team as a code owner December 5, 2023 17:50
Perksey
Perksey approved these changes Dec 5, 2023
View reviewed changes
Copy link
Member

@Perksey Perksey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@Perksey Perksey enabled auto-merge (squash) December 5, 2023 17:54
@Perksey Perksey linked an issue Dec 5, 2023 that may be closed by this pull request
OpenAL ReopenDevices extension doesn't work #1823
Closed
@Perksey Perksey merged commit bc7d8a0 into dotnet:main Dec 5, 2023
5 checks passed
@okaniku okaniku deleted the Fix_AL_ReopenDevices_Extension branch December 6, 2023 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Perksey Perksey Perksey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Silk.NET Development Tracker
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

OpenAL ReopenDevices extension doesn't work
3 participants
@okaniku @Perksey @doobah