Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove problematic implicit in overloads #673

Merged
merged 1 commit into from
Nov 5, 2021
Merged

Remove problematic implicit in overloads #673

merged 1 commit into from
Nov 5, 2021

Conversation

Perksey
Copy link
Member

@Perksey Perksey commented Nov 5, 2021

Does what it says on the tin.

@Perksey Perksey added bug Something isn't working area-OpenGL labels Nov 5, 2021
@Perksey Perksey requested a review from a team November 5, 2021 20:50
@Perksey Perksey mentioned this pull request Nov 5, 2021
Merged
HurricanKai
HurricanKai requested changes Nov 5, 2021
View reviewed changes
Copy link
Member

@HurricanKai HurricanKai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems the span overloader relies on the in overloader to then generate .... in span.GetPinnableReference()
It should instead just use fixed and pass the pointer.

@Perksey
Copy link
Member Author

Perksey commented Nov 5, 2021 •
edited
Loading

Ok but a Span is invalid here too? Anywhere where a span is applicable a ref is applicable, so it's a sane dependency.

@HurricanKai
Copy link
Member

Yeah, I agree. But some of these methods seem like a ref is reasonable?

@Perksey
Copy link
Member Author

Perksey commented Nov 5, 2021

Nope, none of them :D All of these refer to pointers in the vertex layout, not actual CPU memory pointers.

HurricanKai
HurricanKai approved these changes Nov 5, 2021
View reviewed changes
Copy link
Member

@HurricanKai HurricanKai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know enough about OpenGL to disagree so LGTM

@Perksey Perksey merged commit b7732ad into main Nov 5, 2021
@Perksey Perksey deleted the hotfix/remove-bad-overloads branch November 5, 2021 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HurricanKai HurricanKai HurricanKai approved these changes

Assignees
No one assigned
Labels
area-OpenGL bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Perksey @HurricanKai