Fix Bulk Copy Json tests (#2918)

dotnet · Oct 22, 2024 · 576de46 · 576de46
1 parent 337a18f
commit 576de46
Showing 1 changed file with 2 additions and 12 deletions.
diff --git a/src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/JsonTest/JsonBulkCopyTest.cs b/src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/JsonTest/JsonBulkCopyTest.cs
@@ -17,7 +17,6 @@ public class JsonBulkCopyTest
         private readonly ITestOutputHelper _output;
         private static readonly string _jsonFile = "randomRecords.json";
         private static readonly string _outputFile = "serverRecords.json";
-        private static readonly bool _isTestEnabled = DataTestUtility.IsJsonSupported;
 
         public JsonBulkCopyTest(ITestOutputHelper output)
         {
@@ -237,18 +236,13 @@ private async Task BulkCopyDataAsync(CommandBehavior cb, bool enableStraming)
             }
         }
 
-        [Theory]
         [InlineData(CommandBehavior.Default, false)]
         [InlineData(CommandBehavior.Default, true)]
         [InlineData(CommandBehavior.SequentialAccess, false)]
         [InlineData(CommandBehavior.SequentialAccess, true)]
+        [ConditionalTheory(typeof(DataTestUtility), nameof(DataTestUtility.IsJsonSupported))]
         public void TestJsonBulkCopy(CommandBehavior cb, bool enableStraming)
         {
-            if (!_isTestEnabled)
-            {
-                return;
-            }
-
             PopulateData(10000);
             using (SqlConnection connection = new SqlConnection(DataTestUtility.TCPConnectionString))
             {
@@ -261,17 +255,13 @@ public void TestJsonBulkCopy(CommandBehavior cb, bool enableStraming)
             }
         }
 
-        [Theory]
         [InlineData(CommandBehavior.Default, false)]
         [InlineData(CommandBehavior.Default, true)]
         [InlineData(CommandBehavior.SequentialAccess, false)]
         [InlineData(CommandBehavior.SequentialAccess, true)]
+        [ConditionalTheory(typeof(DataTestUtility), nameof(DataTestUtility.IsJsonSupported))]
         public async Task TestJsonBulkCopyAsync(CommandBehavior cb, bool enableStraming)
         {
-            if (!_isTestEnabled)
-            {
-                return;
-            }
             PopulateData(10000);
             using (SqlConnection connection = new SqlConnection(DataTestUtility.TCPConnectionString))
             {