Skip to content

Commit

Permalink
Add | No-op if engineedition is 6 or 11 due to lack of support for AS…
Browse files Browse the repository at this point in the history
…SEMBLYPROPERTY function (#2593)
  • Loading branch information
ErikEJ authored Jun 26, 2024
1 parent 8777fce commit eb46c58
Showing 1 changed file with 7 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
// See the LICENSE file in the project root for more information.

using System;
using System.Collections.Generic;
using System.Data;
using System.Data.Common;
using System.IO;
Expand All @@ -17,7 +18,7 @@ internal sealed class SqlMetaDataFactory : DbMetaDataFactory

private const string ServerVersionNormalized90 = "09.00.0000";
private const string ServerVersionNormalized10 = "10.00.0000";

private readonly HashSet<int> _assemblyPropertyUnsupportedEngines = new() { 6, 9, 11 };

public SqlMetaDataFactory(Stream XMLStream,
string serverVersion,
Expand Down Expand Up @@ -51,11 +52,13 @@ private void addUDTsToDataTypesTable(DataTable dataTypesTable, SqlConnection con

SqlCommand engineEditionCommand = connection.CreateCommand();
engineEditionCommand.CommandText = "SELECT SERVERPROPERTY('EngineEdition');";
var engineEdition = (int)engineEditionCommand.ExecuteScalar()!;
var engineEdition = (int)engineEditionCommand.ExecuteScalar();

if (engineEdition == 9)
if (_assemblyPropertyUnsupportedEngines.Contains(engineEdition))
{
// Azure SQL Edge throws an exception when querying sys.assemblies
// Azure SQL Edge (9) throws an exception when querying sys.assemblies
// Azure Synapse Analytics (6) and Azure Synapse serverless SQL pool (11)
// do not support ASSEMBLYPROPERTY
return;
}

Expand Down

0 comments on commit eb46c58

Please sign in to comment.