Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ref reference to System.Security.Cryptography.Cng #2574

Closed
David-Engel opened this issue Jun 15, 2024 · 1 comment · Fixed by #2577
Closed

Remove ref reference to System.Security.Cryptography.Cng #2574

David-Engel opened this issue Jun 15, 2024 · 1 comment · Fixed by #2577

Comments

@David-Engel
Copy link
Contributor

After removing support for .NET Standard, references to System.Security.Cryptography.Cng were removed but one was left in the ref project:

SqlClient/src/Microsoft.Data.SqlClient/netcore/ref/Microsoft.Data.SqlClient.csproj

Line 21 in 689cc25

<PackageReference Include="System.Security.Cryptography.Cng" Version="$(SystemSecurityCryptographyCngVersion)" />

This should be removed.

Once done, #2048 can be closed.
@ErikEJ
Copy link
Contributor

ErikEJ commented Jun 15, 2024

@David-Engel I will have a look

ErikEJ added a commit to ErikEJ/SqlClient that referenced this issue Jun 15, 2024
@ErikEJ
Remove unused reference
1a322fa 
fixes dotnet#2574
fixes dotnet#2048

Related Work Items: #2
@ErikEJ ErikEJ mentioned this issue Jun 15, 2024
Closed
ErikEJ added a commit to ErikEJ/SqlClient that referenced this issue Jun 17, 2024
@ErikEJ
fixes dotnet#2574
8f643a6 
fixes dotnet#2048

removes explicit ref to Microsoft.Identity.Client
@ErikEJ ErikEJ mentioned this issue Jun 17, 2024
Merged
@arellegue arellegue added the 🆕 Triage Needed For new issues, not triaged yet. label Jun 17, 2024
@kf-gonzalez2 kf-gonzalez2 removed the 🆕 Triage Needed For new issues, not triaged yet. label Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
SqlClient Triage Board
Status: Closed
Milestone
No milestone
4 participants
@ErikEJ @David-Engel @arellegue @kf-gonzalez2