Do not add parameters for sp_describe_parameter_encryption when not provided #1115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cheenamalhotra
approved these changes
Jun 25, 2021
DavoudEshtehari
approved these changes
Jul 8, 2021
src/Microsoft.Data.SqlClient/tests/ManualTests/AlwaysEncrypted/ApiShould.cs
Outdated
Show resolved
Hide resolved
DavoudEshtehari
pushed a commit
to Wraith2/SqlClient
that referenced
this pull request
Sep 1, 2021
…rovided (dotnet#1115) * Update SqlCommand.cs * only execute sp_describe_parameter_encryption if parameters not empty * add test * improve test coverage * only go through parameters if not null * revert previous attempt * Update ApiShould.cs * Update ApiShould.cs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1105
The exception occurs when the driver tries to execute
sp_describe_parameter_encryptionbut no user parameters have been provided.Current behaviour for always encrypted with secure enclaves:
When executing a stored procedure that does not require an input parameter:
sp_describe_parameter_encryptionbut parameters are null. Should succeed by sending empty parameter list forsp_describe_parameter_encryptionWhen executing a stored procedure that requires an input parameter but none are provided by the user:
sp_describe_parameter_encryptionbut parameters are null. Should fail with "Microsoft.Data.SqlClient.SqlException (0x80131904): Procedure or function '[name of sp]' expects parameter '@[name of param]', which was not supplied."This change fixes both unexpected behaviours above.