-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop Asynchronous Processing connection property + Improve connection string docs #1148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
johnnypham
commented
Jul 5, 2021
•
edited by cheenamalhotra
Loading
edited by cheenamalhotra
- Removes "Asynchronous Processing" connection property (obsolete and non-active for netfx)
- Synchronize docs for connection properties
doc/snippets/Microsoft.Data.SqlClient/SqlConnectionStringBuilder.xml
Outdated
Show resolved
Hide resolved
doc/snippets/Microsoft.Data.SqlClient/SqlConnectionStringBuilder.xml
Outdated
Show resolved
Hide resolved
doc/snippets/Microsoft.Data.SqlClient/SqlConnectionStringBuilder.xml
Outdated
Show resolved
Hide resolved
doc/snippets/Microsoft.Data.SqlClient/SqlConnectionStringBuilder.xml
Outdated
Show resolved
Hide resolved
doc/snippets/Microsoft.Data.SqlClient/SqlConnectionStringBuilder.xml
Outdated
Show resolved
Hide resolved
cheenamalhotra
added
the
Area\Documentation
Issue that requires changes in public documentations/samples.
label
Jul 5, 2021
…er.xml Co-authored-by: Cheena Malhotra <v-chmalh@microsoft.com>
…er.xml Co-authored-by: Cheena Malhotra <v-chmalh@microsoft.com>
…er.xml Co-authored-by: Cheena Malhotra <v-chmalh@microsoft.com>
…er.xml Co-authored-by: Cheena Malhotra <v-chmalh@microsoft.com>
cheenamalhotra
added
the
🔨 Breaking Change
Issues/PRs that are related with breaking API changes in the driver.
label
Jul 6, 2021
cheenamalhotra
approved these changes
Jul 6, 2021
cheenamalhotra
changed the title
Improve connection string docs
Drop Asynchronous Processing connection property + Improve connection string docs
Jul 6, 2021
David-Engel
reviewed
Jul 7, 2021
doc/snippets/Microsoft.Data.SqlClient/SqlConnectionStringBuilder.xml
Outdated
Show resolved
Hide resolved
doc/snippets/Microsoft.Data.SqlClient/SqlConnectionStringBuilder.xml
Outdated
Show resolved
Hide resolved
Co-authored-by: David Engel <dengel1012@gmail.com>
David-Engel
approved these changes
Jul 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Area\Documentation
Issue that requires changes in public documentations/samples.
🔨 Breaking Change
Issues/PRs that are related with breaking API changes in the driver.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.