Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix | Exclude unsupported protocols #1168

Merged
merged 8 commits into from
Aug 23, 2021
Merged

Fix | Exclude unsupported protocols #1168

merged 8 commits into from
Aug 23, 2021

Conversation

DavoudEshtehari
Copy link
Contributor

@DavoudEshtehari DavoudEshtehari commented Jul 13, 2021 •
edited by cheenamalhotra
Loading

This change covers Managed SNI.
There is an internal PR for Native SNI too.

  • To use OS enabled client protocols instead, you must enable the following switch:
  "Switch.Microsoft.Data.SqlClient.UseSystemDefaultSecureProtocols"

related issue #1151

@DavoudEshtehari DavoudEshtehari added 🐛 Bug! Issues that are bugs in the drivers we maintain. Area\Managed SNI Issues that are targeted to the Managed SNI codebase. Area\Netcore Issues that are apply only to .NET runtime or the 'netcore' project folder. labels Jul 13, 2021
@cheenamalhotra cheenamalhotra added this to the 4.0.0-preview1 milestone Jul 16, 2021
@JRahnama
Copy link
Contributor

LGTM. Is it possible to have some tests for this?

@DavoudEshtehari DavoudEshtehari linked an issue Jul 16, 2021 that may be closed by this pull request
Cannot connect when OS has TLS1.3 (and TLS1.2) enabled #1151
Closed
@cheenamalhotra
Copy link
Member

Just FYI - requires Native SNI release and version upgrade as well to fix the issue completely.

@DavoudEshtehari DavoudEshtehari force-pushed the GHIssue/TLSIssue#1151 branch from 86df111 to 53cc74f Compare July 28, 2021 20:31
@cheenamalhotra cheenamalhotra removed this from the 4.0.0-preview1 milestone Jul 28, 2021
ErikEJ
ErikEJ reviewed Jul 29, 2021
View reviewed changes
BUILDGUIDE.md Outdated Show resolved Hide resolved
David-Engel
David-Engel reviewed Jul 30, 2021
View reviewed changes
BUILDGUIDE.md Outdated Show resolved Hide resolved
src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/SNI/SNIHandle.cs Outdated Show resolved Hide resolved
BUILDGUIDE.md Show resolved Hide resolved
@cheenamalhotra cheenamalhotra added this to the 4.0.0-preview1 milestone Jul 30, 2021
@DavoudEshtehari DavoudEshtehari removed Area\Netcore Issues that are apply only to .NET runtime or the 'netcore' project folder. Area\Managed SNI Issues that are targeted to the Managed SNI codebase. labels Jul 30, 2021
@cheenamalhotra cheenamalhotra mentioned this pull request Aug 20, 2021
Merged
@DavoudEshtehari @David-Engel
Apply suggestions from code review
7fdb9d2 
Co-authored-by: David Engel <dengel1012@gmail.com>
@cheenamalhotra cheenamalhotra removed the 🐛 Bug! Issues that are bugs in the drivers we maintain. label Aug 23, 2021
@cheenamalhotra cheenamalhotra merged commit 8b77c49 into dotnet:main Aug 23, 2021
@cheenamalhotra cheenamalhotra added the 🆕 Public API Issues/PRs that introduce new APIs to the driver. label Aug 23, 2021
@DavoudEshtehari DavoudEshtehari mentioned this pull request Nov 19, 2021
Merged
@JRahnama JRahnama removed the request for review from johnnypham July 15, 2022 22:14
@DavoudEshtehari DavoudEshtehari mentioned this pull request Nov 2, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@David-Engel David-Engel David-Engel left review comments

@ErikEJ ErikEJ ErikEJ left review comments

@JRahnama JRahnama JRahnama approved these changes

@cheenamalhotra cheenamalhotra cheenamalhotra approved these changes

Assignees
No one assigned
Labels
🆕 Public API Issues/PRs that introduce new APIs to the driver.
Projects
None yet
Milestone
4.0.0-preview1
Development

Successfully merging this pull request may close these issues.

Cannot connect when OS has TLS1.3 (and TLS1.2) enabled
5 participants
@DavoudEshtehari @JRahnama @cheenamalhotra @ErikEJ @David-Engel