FIX | DbType when it is set to Time in SqlEnums #1169
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JRahnama
requested review from
cheenamalhotra,
johnnypham,
David-Engel and
DavoudEshtehari
JRahnama
changed the title
|
The change was made in 2019 by the PR #269. The way driver acts is by design and it is not a bug or issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1164
Looks like an oversight porting from SDS. When DBType is set to Time SDS is behaving differently than MDS. MDS acts same as
SqlDbTypewhereas inSqlEnumsThere are two different methodsGetMetaTypeFromDbTypeandGetMetaTypeFromSqlDbTypechanging the Switch statement inGetMetaTypeFromDbTypeto same as SDS solved the issue.