Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup StringsHelper #1236

Merged
merged 3 commits into from
Sep 17, 2021
Merged

Cleanup StringsHelper #1236

merged 3 commits into from
Sep 17, 2021

Conversation

cheenamalhotra
Copy link
Member

@cheenamalhotra cheenamalhotra added the ➕ Code Health Issues/PRs that are targeted to source code quality improvements. label Aug 30, 2021
@Wraith2
Copy link
Contributor

Wraith2 commented Aug 30, 2021

Nice. I like PR's which are deleting lots of things. 😁

@cheenamalhotra
Copy link
Member Author

cheenamalhotra commented Aug 30, 2021 •
edited
Loading

I would have liked it to be cleaned in the initial PR itself but I was too busy with other things, didn't get time to dig in review for the second time.. so this one was on me!

@cheenamalhotra cheenamalhotra added this to the 4.0.0-preview2 milestone Aug 31, 2021
cheenamalhotra and others added 2 commits September 15, 2021 16:47
@cheenamalhotra @DavoudEshtehari
Apply suggestions from code review
1364af2 
Co-authored-by: DavoudEshtehari <61173489+DavoudEshtehari@users.noreply.github.com>
@cheenamalhotra
Fix for sqlparameter
038d85a
@cheenamalhotra cheenamalhotra merged commit c9147a6 into dotnet:main Sep 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavoudEshtehari DavoudEshtehari DavoudEshtehari approved these changes

@Kaur-Parminder Kaur-Parminder Kaur-Parminder approved these changes

@JRahnama JRahnama Awaiting requested review from JRahnama

@johnnypham johnnypham Awaiting requested review from johnnypham

Assignees
No one assigned
Labels
➕ Code Health Issues/PRs that are targeted to source code quality improvements.
Projects
None yet
Milestone
4.0.0-preview2
Development

Successfully merging this pull request may close these issues.
4 participants
@cheenamalhotra @Wraith2 @DavoudEshtehari @Kaur-Parminder