-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move into shared for TimeoutTimer.cs #1273
Conversation
You probably don't want to include it in the netfx project file until it's used by something in the netfx build. |
Thanks for the recommendation. I did verify it's being referenced in the netfx project in |
src/Microsoft.Data.SqlClient/netcore/src/Microsoft.Data.SqlClient.csproj
Outdated
Show resolved
Hide resolved
… rest of the ProviderBase in the netfx csproj
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a minor naming rule violation here: internal static readonly long s_infiniteTimeout = 0;
Plus an extra blank line at the end of TimeoutTimer.cs
.
In regards to issue #1261, I moved the TimeoutTimer.cs from the dotnet to src and updated the reference from the netfx version