Move to Shared for SqlEnums.cs #1317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e references in the csprojs
Kaur-Parminder
added
the
➕ Code Health
johnnypham
approved these changes
Oct 5, 2021
|
NIT: @lcheunglci All methods from TypeId to GetMetaTypeFromValue can use body expressions except GetMetaTypeFromSqlDbType. |
Kaur-Parminder
approved these changes
Oct 13, 2021
JRahnama
approved these changes
Oct 14, 2021
…e references in the csprojs
…and updated references in the csprojs and fix compiler error removing internal method with no references (dotnet#1303)
…e references in the csprojs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #1261 . I merged the netfx changes into netcore, and move it to shared src. I updated to the code to conform with the coding style, but left the IDE1006 ones because renaming the static variables with _s and internal read-only fields with _ affected other files i.e. SqlDataReader, SqlDataRecord, SqlUtil, SqlParameter, TdsParser, SqlComand, and more, which are all on the list to be merged, so I wanted to keep the changes small.