Move to Shared SqlSequentialTextReader #1343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is part of dotnet#1261 code merge effort, Moved the file to common folder.
Kaur-Parminder
added
the
➕ Code Health
lcheunglci
approved these changes
Oct 19, 2021
Kaur-Parminder
requested review from
JRahnama,
johnnypham and
DavoudEshtehari
johnnypham
reviewed
Jan 21, 2022
src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlSequentialTextReader.cs
Outdated
Show resolved
Hide resolved
SNI Update
This reverts commit 7aebf45.
johnnypham
reviewed
Apr 4, 2022
src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlSequentialTextReader.cs
Outdated
Show resolved
Hide resolved
johnnypham
reviewed
Apr 4, 2022
src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlSequentialTextReader.cs
Outdated
Show resolved
Hide resolved
johnnypham
approved these changes
Apr 4, 2022
DavoudEshtehari
approved these changes
Apr 6, 2022
JRahnama
approved these changes
Apr 6, 2022
|
Should this be moved to Done on the project? I noticed a few others that are done but still listed in “Review in progress". |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of #1261 code merge effort, Moved the file to common folder.