-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Porting SqlDataSourceEnumerator from System.Data.Sql #1428
[WIP] Porting SqlDataSourceEnumerator from System.Data.Sql #1428
Conversation
Porting SqlDataSourceEnumerater feature from System.Data.Sql
Netfx SNINativeWrapper changes
src/Microsoft.Data.SqlClient/src/Microsoft/Data/Sql/SqlDataSourceEnumerator.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/src/Microsoft/Data/Sql/SqlDataSourceEnumerator.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/src/Microsoft/Data/Sql/SqlDataSourceEnumerator.cs
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/src/Microsoft/Data/Sql/SqlDataSourceEnumerator.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/Interop/SNINativeMethodWrapper.cs
Outdated
Show resolved
Hide resolved
Is there going to be a managed implementation provided for the non-windows builds? If so would it be possible to use that one on all builds and avoid introducing new code that perpetuates the managed vs native sni. |
|
Ok. As long as it's a consideration. I can see that it might be a good first step to use the native implementation so the results can be tested. In the long term the plan to move this library to a managed only implementation would mean that it's important to have a high quality managed implementation. |
addressing reviewer's comment
I am closing this PR as all the work done here is moved to #1430 |
This PR ports feature from System.Data.Sql for SqlDataSourceEnumerator.GetDataSources Method . SNI changes will be available with next preview release.