Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test | Replacing Binary formatter with DataContractSerializer #1590

Merged
merged 11 commits into from
Aug 19, 2022

Conversation

Kaur-Parminder
Copy link
Contributor

Addressing build error (ReferrenceType = NetStandard) 'BinaryFormatter.Serialize(Stream, object)' is obsolete: 'BinaryFormatter serialization is obsolete and should not be used.

@johnnypham
Copy link
Contributor

Is DataContractSerializer being used properly? DataContractAttribute and DataMemberAttribute attributes have to be applied to classes and members that should be serialized but there aren't any of these attributes in SqlError.

@Kaur-Parminder
Copy link
Contributor Author

Is DataContractSerializer being used properly? DataContractAttribute and DataMemberAttribute attributes have to be applied to classes and members that should be serialized but there aren't any of these attributes in SqlError.

Test is using only primitive types for validation in SqlError class.

@codecov
Copy link

codecov bot commented May 16, 2022

Codecov Report

Merging #1590 (72d3c31) into main (35d9ffe) will increase coverage by 0.38%.
The diff coverage is 54.17%.

❗ Current head 72d3c31 differs from pull request most recent head 0e428cc. Consider uploading reports for the commit 0e428cc to get more accurate results

@@            Coverage Diff             @@
##             main    #1590      +/-   ##
==========================================
+ Coverage   69.68%   70.07%   +0.38%     
==========================================
  Files         331      328       -3     
  Lines       66503    64524    -1979     
==========================================
- Hits        46345    45216    -1129     
+ Misses      20158    19308     -850     
Flag Coverage Δ
addons 92.38% <ø> (ø)
netcore 72.42% <60.39%> (+0.49%) ⬆️
netfx 69.26% <57.82%> (+1.24%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...on/src/System/Net/Logging/NetEventSource.Common.cs 0.69% <ø> (ø)
...core/src/Interop/SNINativeMethodWrapper.Windows.cs 98.82% <ø> (ø)
...t/netcore/src/Microsoft/Data/SqlClient/SNI/SSRP.cs 0.00% <0.00%> (ø)
.../Microsoft/Data/SqlClient/SqlInternalConnection.cs 75.47% <ø> (ø)
...fx/src/Microsoft/Data/SqlClient/SqlBuffer.netfx.cs 0.00% <0.00%> (ø)
...t/netfx/src/Microsoft/Data/SqlClient/SqlCommand.cs 72.62% <0.00%> (+0.06%) ⬆️
...x/src/Microsoft/Data/SqlClient/SqlDataReaderSmi.cs 0.00% <0.00%> (ø)
.../Microsoft/Data/SqlClient/SqlInternalConnection.cs 72.33% <ø> (ø)
...t/Data/SqlClient/NoneAttestationEnclaveProvider.cs 90.69% <0.00%> (+90.69%) ⬆️
...osoft/Data/SqlClient/Server/ValueUtilsSmi.netfx.cs 17.37% <0.00%> (ø)
... and 65 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6625b3...0e428cc. Read the comment docs.

@JRahnama JRahnama merged commit bd21d76 into dotnet:main Aug 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants