Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix | Default UTF8 collation conflict #1739

Merged
merged 3 commits into from
Aug 31, 2022
Merged

Fix | Default UTF8 collation conflict #1739

merged 3 commits into from
Aug 31, 2022

Conversation

DavoudEshtehari
Copy link
Contributor

@DavoudEshtehari DavoudEshtehari commented Aug 25, 2022 •
edited
Loading

Issue: Defining a database with UTF8 collation overrides its column's collation with the same LCID.

@DavoudEshtehari DavoudEshtehari added 🐛 Bug! Issues that are bugs in the drivers we maintain. Area\Netfx Issues that are apply only to .NET Framework or the 'netfx' project folder. labels Aug 25, 2022
@DavoudEshtehari DavoudEshtehari added this to the 5.1.0-preview1 milestone Aug 25, 2022
@codecov
Copy link

codecov bot commented Aug 25, 2022 •
edited
Loading

Codecov Report

Base: 71.50% // Head: 71.41% // Decreases project coverage by -0.08% ⚠️

Coverage data is based on head (44cc27f) compared to base (bd21d76).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1739      +/-   ##
==========================================
- Coverage   71.50%   71.41%   -0.09%     
==========================================
  Files         293      293              
  Lines       61385    61376       -9     
==========================================
- Hits        43892    43831      -61     
- Misses      17493    17545      +52
Flag Coverage Δ
addons 92.38% <ø> (ø)
netcore 74.98% <ø> (-0.08%) ⬇️
netfx 69.26% <100.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...nt/netfx/src/Microsoft/Data/SqlClient/TdsParser.cs 70.96% <100.00%> (-0.41%) ⬇️
...ActiveDirectoryAuthenticationTimeoutRetryHelper.cs 56.81% <0.00%> (-6.82%) ⬇️
...e/src/Microsoft/Data/SqlClient/SNI/SNITcpHandle.cs 59.25% <0.00%> (-3.96%) ⬇️
...t/netcore/src/Microsoft/Data/SqlClient/SNI/SSRP.cs 49.24% <0.00%> (-3.36%) ⬇️
...crosoft/Data/SqlClient/SqlInternalConnectionTds.cs 72.98% <0.00%> (-0.40%) ⬇️
...osoft/Data/SqlClient/SqlConnectionStringBuilder.cs 88.58% <0.00%> (-0.39%) ⬇️
...c/Microsoft/Data/SqlClient/TdsParserStateObject.cs 81.87% <0.00%> (-0.30%) ⬇️
...crosoft/Data/SqlClient/SqlInternalConnectionTds.cs 67.36% <0.00%> (-0.27%) ⬇️
...c/Microsoft/Data/SqlClient/TdsParserStateObject.cs 81.50% <0.00%> (-0.23%) ⬇️
... and 9 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@DavoudEshtehari DavoudEshtehari marked this pull request as ready for review August 30, 2022 03:50
@DavoudEshtehari @lcheunglci
Apply suggestions from code review
44cc27f 
Co-authored-by: Lawrence LCI <31262254+lcheunglci@users.noreply.github.com>
@DavoudEshtehari DavoudEshtehari merged commit 4cb2b67 into dotnet:main Aug 31, 2022
DavoudEshtehari added a commit to DavoudEshtehari/SqlClient that referenced this pull request Sep 1, 2022
@DavoudEshtehari
Fix | Default UTF8 collation conflict (dotnet#1739)
52dc775
@DavoudEshtehari DavoudEshtehari mentioned this pull request Sep 1, 2022
Merged
DavoudEshtehari added a commit to DavoudEshtehari/SqlClient that referenced this pull request Sep 1, 2022
@DavoudEshtehari
Fix | Default UTF8 collation conflict (dotnet#1739)
5a0101d
@DavoudEshtehari DavoudEshtehari mentioned this pull request Sep 1, 2022
Merged
DavoudEshtehari added a commit that referenced this pull request Sep 8, 2022
@DavoudEshtehari
Fix | Default UTF8 collation conflict (#1739) (#1750)
2ef10cd
DavoudEshtehari added a commit that referenced this pull request Sep 8, 2022
@DavoudEshtehari
[Hotfix 4.1.1] | Fix default UTF8 collation conflict (#1739) (#1749)
200e442
@David-Engel David-Engel mentioned this pull request Oct 7, 2022
Merged
Kaur-Parminder added a commit to Kaur-Parminder/SqlClient that referenced this pull request Jan 31, 2023
@Kaur-Parminder
Backport: Fix | Default UTF8 collation conflict
6a67090 
(dotnet#1739)
@Kaur-Parminder Kaur-Parminder mentioned this pull request Jan 31, 2023
Merged
DavoudEshtehari added a commit to DavoudEshtehari/SqlClient that referenced this pull request Apr 11, 2023
@DavoudEshtehari
Fix | Default UTF8 collation conflict (dotnet#1739)
2189f6c 
# Conflicts:
#	src/Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/SqlClient/TdsParser.cs
@DavoudEshtehari DavoudEshtehari mentioned this pull request Apr 11, 2023
Merged
JRahnama pushed a commit that referenced this pull request Apr 17, 2023
@DavoudEshtehari
[2.1.6] Fix | Default UTF8 collation conflict (#1739) (#1989)
e32dc56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lcheunglci lcheunglci lcheunglci approved these changes

@David-Engel David-Engel David-Engel approved these changes

@JRahnama JRahnama Awaiting requested review from JRahnama

@Kaur-Parminder Kaur-Parminder Awaiting requested review from Kaur-Parminder

Assignees
No one assigned
Labels
Area\Netfx Issues that are apply only to .NET Framework or the 'netfx' project folder. 🐛 Bug! Issues that are bugs in the drivers we maintain.
Projects
None yet
Milestone
5.1.0-preview1
Development

Successfully merging this pull request may close these issues.
3 participants
@DavoudEshtehari @David-Engel @lcheunglci