-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix] Hang on infinite timeout and managed SNI #1742
Conversation
Also fix SSRP when DataSource is an IP address
Codecov ReportBase: 71.50% // Head: 71.35% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1742 +/- ##
==========================================
- Coverage 71.50% 71.35% -0.15%
==========================================
Files 293 293
Lines 61385 61378 -7
==========================================
- Hits 43892 43799 -93
- Misses 17493 17579 +86
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
* Fix for issue dotnet#1733 - hang on infinite timeout Also fix SSRP when DataSource is an IP address
* Fix for issue dotnet#1733 - hang on infinite timeout Also fix SSRP when DataSource is an IP address
Fixes #1733 - regression introduced in #1578
I moved DNS calls into a common function and added logging for it. I decided not to use async DNS calls because the timeout logic is just wrong and I wanted to limit this fix to the issue at hand. The timeout logic will be addressed in a future PR.
I did notice and fix 2 issues in the SSRP logic right around the same DNS logic being fixed.