-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Experimental: Add ARM64 support when targeting .NET Framework #1828
Conversation
src/Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/Interop/SNINativeManagedWrapperX64.cs
Outdated
Show resolved
Hide resolved
Codecov ReportBase: 71.47% // Head: 71.22% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1828 +/- ##
==========================================
- Coverage 71.47% 71.22% -0.25%
==========================================
Files 291 291
Lines 61304 61391 +87
==========================================
- Hits 43814 43725 -89
- Misses 17490 17666 +176
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
… the new SNI version
Hi @David-Engel / @JRahnama Nice! When can I expect this to show up in MDS3.x? Pretty please... :) It would HELP our users on Visual Studio 2022 and SSDT (17.5 Previews) which is on MDS3.1.1 a lot. We can chat offline and bounce around ideas with other folks who are working on this (I'm just the messenger for now). |
The CI pipelines don't run tests on ARM64 + .NET Framework and I'm having a hard time getting an ARM64 Windows VM to build + run MDS tests from the command line with VS 2022 Preview 6 installed.
Test can be run through the VS GUI, though, you just have to manually filter through expected failures. Doing that identified a bug in the build options of the ARM SNI binaries that resulted in asserts popping up even when using the release binaries. That will be addressed separately in a future SNI release.
Consider this "feature" experimental, for now.