Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix | Addressing regression from removing NETSTANDARD2.1 constant #1867

Merged

Conversation

JRahnama
Copy link
Contributor

@JRahnama JRahnama commented Dec 9, 2022

Built-in constant is added to replace the removed defined constant.

@codecov
Copy link

codecov bot commented Dec 9, 2022

Codecov Report

Base: 70.61% // Head: 70.34% // Decreases project coverage by -0.27% ⚠️

Coverage data is based on head (439eaff) compared to base (22eb6c7).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1867      +/-   ##
==========================================
- Coverage   70.61%   70.34%   -0.28%     
==========================================
  Files         292      292              
  Lines       61727    61727              
==========================================
- Hits        43591    43419     -172     
- Misses      18136    18308     +172     
Flag Coverage Δ
addons 92.38% <ø> (ø)
netcore 73.50% <ø> (-0.62%) ⬇️
netfx 69.20% <ø> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...c/Microsoft/Data/SqlClient/TdsParserStateObject.cs 23.30% <0.00%> (-21.08%) ⬇️
...ata/SqlClient/SqlConnectionTimeoutErrorInternal.cs 41.96% <0.00%> (-18.75%) ⬇️
...c/Microsoft/Data/SqlClient/SqlConnectionFactory.cs 68.85% <0.00%> (-0.82%) ⬇️
...rc/Microsoft/Data/ProviderBase/DbConnectionPool.cs 85.19% <0.00%> (-0.67%) ⬇️
...c/Microsoft/Data/SqlClient/TdsParserStateObject.cs 66.46% <0.00%> (-0.52%) ⬇️
...nt/netcore/src/Microsoft/Data/SqlClient/SqlUtil.cs 48.90% <0.00%> (-0.48%) ⬇️
...rc/Microsoft/Data/ProviderBase/DbConnectionPool.cs 86.21% <0.00%> (-0.30%) ⬇️
...crosoft/Data/SqlClient/SqlInternalConnectionTds.cs 67.80% <0.00%> (-0.27%) ⬇️
...netcore/src/Microsoft/Data/SqlClient/SqlCommand.cs 83.99% <0.00%> (+0.10%) ⬆️
...nt/netfx/src/Microsoft/Data/SqlClient/TdsParser.cs 71.15% <0.00%> (+0.30%) ⬆️
... and 7 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@David-Engel David-Engel merged commit b3cfdbb into dotnet:main Dec 9, 2022
@JRahnama JRahnama added this to the 5.1.0 milestone Dec 9, 2022
@JRahnama JRahnama deleted the address-regression-netstandard-constant branch September 8, 2023 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants