-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add | Add net8 compatibility #1934
Conversation
I will do some changes to this PR, such as the csproj file to include SqlTypeWorkarounds to be included if it is net6 only and changing the Net 8 to net 7 for now. |
You can't change the net8 to 7 because this is adding support for new apis that aren't in 7. For the rest, go ahead. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1934 +/- ##
==========================================
- Coverage 70.82% 70.67% -0.16%
==========================================
Files 292 305 +13
Lines 61777 61794 +17
==========================================
- Hits 43752 43670 -82
- Misses 18025 18124 +99
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
The new APIs made it into .net7 last year. I think we are good to go on this PR. |
follow up changes for PR dotnet#1934
follow up changes for PR dotnet#1934
) follow up changes for PR dotnet#1934
closes #1930
In netcore builds SqlGuidCaster and the type workaround that used it are not required. The problem they solved has already been change to use the ReadOnlySpan ctor. The SqlGuid workarounds in netcore are removed. Netfx builds use a more recent approach to the original problem and do not need to change.
I have also added ifdeffed use of the new api's introduced to the ryntime in dotnet/runtime#72724 so if/when a net8 build is created the new methods will be used and the workarounds will be ifdeffed out entirely.
Testing on net was done manually with a small repro app that used reflection to force SqlGuidCaster to be compiled. Before these change the reported TypeLoadException was encountered, after them it is not.
/cc @Alerinos @MichalPetryka