Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support SuperSocketNetLib registry option for Encrypt on NetCore Windows #2047

Merged
merged 1 commit into from
Jul 7, 2023

Conversation

David-Engel
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented May 31, 2023

Codecov Report

Patch coverage: 75.00% and project coverage change: -0.31 ⚠️

Comparison is base (f478be5) 70.97% compared to head (b107fc9) 70.67%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2047      +/-   ##
==========================================
- Coverage   70.97%   70.67%   -0.31%     
==========================================
  Files         305      305              
  Lines       61807    61807              
==========================================
- Hits        43870    43681     -189     
- Misses      17937    18126     +189     
Flag Coverage Δ
addons 92.88% <ø> (ø)
netcore 73.44% <75.00%> (-0.18%) ⬇️
netfx 69.27% <75.00%> (-0.34%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rc/Microsoft/Data/SqlClient/SqlConnectionString.cs 72.01% <75.00%> (ø)

... and 19 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@@ -454,6 +442,18 @@ internal SqlConnectionString(string connectionString) : base(connectionString, G
}
#endif // NETFRAMEWORK

if (_encrypt == SqlConnectionEncryptOption.Optional)
{ // Support legacy registry encryption settings
const string folder = "Software\\Microsoft\\MSSQLServer\\Client\\SuperSocketNetLib";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering if this is still a valid path or not!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a less-known, legacy registry path. I don't even see it in current MS docs, but it was in the netfx code (and works in netfx SDS) and support has mentioned it from some customers.

@DavoudEshtehari DavoudEshtehari added this to the 5.2.0-preview3 milestone Jun 14, 2023
@DavoudEshtehari DavoudEshtehari added the Area\Netcore Issues that are apply only to .NET runtime or the 'netcore' project folder. label Jun 14, 2023
@DavoudEshtehari DavoudEshtehari merged commit 3cb9730 into dotnet:main Jul 7, 2023
@David-Engel David-Engel deleted the SuperSocketNetLib branch May 21, 2024 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area\Netcore Issues that are apply only to .NET runtime or the 'netcore' project folder.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants