Fix | LocalDb and managed SNI #2129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavoudEshtehari
added
🐛 Bug!
DavoudEshtehari
force-pushed
the
Adhoc/FixLocaldb
branch
from
1fe1b83
to
7622824
Compare
DavoudEshtehari
commented
Aug 19, 2023
src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/SNI/LocalDB.Windows.cs
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/SNI/SNICommon.cs
Show resolved
Hide resolved
Comment on lines
+161
to
+164
| if (IsNativeSNI()) | ||
| { | ||
| Assert.Contains("The specified LocalDB instance does not exist.", ex.Message); | ||
| } |
There was a problem hiding this comment.
Additional information comes from the native method call in TdsParser by LocalDBAPI.GetLocalDBMessage().
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2129 +/- ##
==========================================
+ Coverage 70.76% 71.00% +0.23%
==========================================
Files 306 305 -1
Lines 62051 61854 -197
==========================================
+ Hits 43910 43918 +8
+ Misses 18141 17936 -205
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
David-Engel
approved these changes
Aug 29, 2023
JRahnama
approved these changes
Sep 1, 2023
DavoudEshtehari
added a commit
to DavoudEshtehari/SqlClient
that referenced
this pull request
Oct 25, 2023
DavoudEshtehari
added a commit
to DavoudEshtehari/SqlClient
that referenced
this pull request
Oct 27, 2023
DavoudEshtehari
added a commit
to DavoudEshtehari/SqlClient
that referenced
this pull request
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved error messages and failure scenarios on managed SNI.