Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge TDSParserStateObject.StateSnapshot creation and clearing #2144

Merged
merged 1 commit into from
Sep 13, 2023
Merged

Merge TDSParserStateObject.StateSnapshot creation and clearing #2144

merged 1 commit into from
Sep 13, 2023

Conversation

Wraith2
Copy link
Contributor

@Wraith2 Wraith2 commented Sep 3, 2023

Moves SetSnapshot and ResetSnapshot to shared. Moves some clear implementation to ClearCore in shared.

@codecov
Copy link

codecov bot commented Sep 4, 2023

Codecov Report

Patch coverage is 100.00% of modified lines.

Files Changed Coverage
...oft/Data/SqlClient/TdsParserStateObject.netcore.cs 100.00%
...osoft/Data/SqlClient/TdsParserStateObject.netfx.cs 100.00%
...c/Microsoft/Data/SqlClient/TdsParserStateObject.cs 100.00%

📢 Thoughts on this report? Let us know!.

David-Engel
David-Engel approved these changes Sep 7, 2023
View reviewed changes
Copy link
Contributor

@David-Engel David-Engel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DavoudEshtehari DavoudEshtehari added this to the 5.2.0-preview4 milestone Sep 13, 2023
@DavoudEshtehari DavoudEshtehari added the 💡 Enhancement Issues that are feature requests for the drivers we maintain. label Sep 13, 2023
@DavoudEshtehari DavoudEshtehari added ➕ Code Health Issues/PRs that are targeted to source code quality improvements. and removed 💡 Enhancement Issues that are feature requests for the drivers we maintain. labels Sep 13, 2023
@DavoudEshtehari DavoudEshtehari merged commit 1e3cbfc into dotnet:main Sep 13, 2023
132 checks passed
@Wraith2 Wraith2 deleted the combine-30 branch September 13, 2023 18:20
@Wraith2 Wraith2 mentioned this pull request Sep 13, 2023
Merged
@panoskj panoskj mentioned this pull request Sep 24, 2023
Merged
@edwardneal edwardneal mentioned this pull request Nov 28, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JRahnama JRahnama JRahnama approved these changes

@David-Engel David-Engel David-Engel approved these changes

@DavoudEshtehari DavoudEshtehari Awaiting requested review from DavoudEshtehari

@arellegue arellegue Awaiting requested review from arellegue

Assignees
No one assigned
Labels
➕ Code Health Issues/PRs that are targeted to source code quality improvements.
Projects
None yet
Milestone
5.2.0-preview4
Development

Successfully merging this pull request may close these issues.
4 participants
@Wraith2 @David-Engel @JRahnama @DavoudEshtehari