SDL | Changing ReadXml to a more secure overload. #2147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wraith2
reviewed
Sep 5, 2023
src/Microsoft.Data.SqlClient/src/Microsoft/Data/ProviderBase/DbMetaDataFactory.cs
Outdated
Show resolved
Hide resolved
Codecov ReportPatch coverage is
📢 Thoughts on this report? Let us know!. |
DavoudEshtehari
approved these changes
Sep 11, 2023
David-Engel
approved these changes
Sep 14, 2023
dauinsight
pushed a commit
to dauinsight/SqlClient
that referenced
this pull request
May 7, 2024
dauinsight
added a commit
that referenced
this pull request
May 8, 2024
dauinsight
added a commit
to dauinsight/SqlClient
that referenced
this pull request
May 16, 2024
…et#2490) Co-authored-by: Javad <v-jarahn@microsoft.com>
dauinsight
added a commit
to dauinsight/SqlClient
that referenced
this pull request
May 17, 2024
… (dotnet#2490)" This reverts commit c6bc5f3.
dauinsight
pushed a commit
to dauinsight/SqlClient
that referenced
this pull request
May 17, 2024
dauinsight
pushed a commit
to dauinsight/SqlClient
that referenced
this pull request
May 17, 2024
DavoudEshtehari
pushed a commit
that referenced
this pull request
May 21, 2024
dauinsight
added a commit
that referenced
this pull request
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code Analysis detected CA3075, Unsafe overload of 'ReadXml' method, for LoadDataSetFromXml. Changing the XmlRead to a more secure overload will solve that issue, by setting XmlResolver to null.