Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix | Invalid transaction exception against the connections and distributed transactions #2301

Merged
merged 1 commit into from
Jan 19, 2024

Conversation

DavoudEshtehari
Copy link
Member

Unsubscribing from a transaction completion event before returning it to the pool is done to prevent potential signals from the previous state.

Fixes #1675

@DavoudEshtehari DavoudEshtehari added the 🐛 Bug! Something isn't right ! label Jan 18, 2024
@DavoudEshtehari DavoudEshtehari added this to the 5.2.0-preview5 milestone Jan 18, 2024
Copy link

codecov bot commented Jan 18, 2024

Codecov Report

Attention: 34 lines in your changes are missing coverage. Please review.

Comparison is base (b12b15d) 72.57% compared to head (8df5a34) 72.50%.
Report is 1 commits behind head on main.

Files Patch % Lines
...c/Microsoft/Data/SqlClient/TdsParserStateObject.cs 86.04% 30 Missing ⚠️
...osoft/Data/SqlClient/TdsParserStateObject.netfx.cs 88.46% 3 Missing ⚠️
...oft/Data/SqlClient/TdsParserStateObject.netcore.cs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2301      +/-   ##
==========================================
- Coverage   72.57%   72.50%   -0.08%     
==========================================
  Files         310      310              
  Lines       62065    61873     -192     
==========================================
- Hits        45041    44858     -183     
+ Misses      17024    17015       -9     
Flag Coverage Δ
addons 92.88% <ø> (ø)
netcore 76.70% <86.58%> (-0.02%) ⬇️
netfx 69.94% <87.15%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DavoudEshtehari DavoudEshtehari merged commit 838b931 into dotnet:main Jan 19, 2024
148 checks passed
JRahnama pushed a commit to JRahnama/SqlClient that referenced this pull request Jan 25, 2024
JRahnama added a commit that referenced this pull request Jan 26, 2024
DavoudEshtehari added a commit that referenced this pull request Mar 28, 2024
DavoudEshtehari added a commit that referenced this pull request Mar 28, 2024
DavoudEshtehari added a commit that referenced this pull request May 8, 2024
DavoudEshtehari added a commit that referenced this pull request May 8, 2024
@ErikEJ ErikEJ mentioned this pull request May 16, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug! Something isn't right !
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TransactionAbortedException when performing queries in parallel inside a transaction scope
3 participants