Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change | Updating AKV dependencies #2330

Merged
merged 2 commits into from
Jan 31, 2024
Merged

Change | Updating AKV dependencies #2330

merged 2 commits into from
Jan 31, 2024

Conversation

JRahnama
Copy link
Member

No description provided.

@JRahnama JRahnama added the 📦 AKV Provider Add-on: Azure Key Vault Provider related label Jan 30, 2024
arellegue
arellegue approved these changes Jan 30, 2024
View reviewed changes
Copy link
Contributor

@arellegue arellegue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@codecov Codecov
Copy link

codecov bot commented Jan 30, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (14d7292) 72.66% compared to head (815750e) 72.61%.
Report is 2 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2330      +/-   ##
==========================================
- Coverage   72.66%   72.61%   -0.06%     
==========================================
  Files         310      310              
  Lines       61877    61877              
==========================================
- Hits        44961    44929      -32     
- Misses      16916    16948      +32
Flag Coverage Δ
addons 92.88% <ø> (ø)
netcore 76.84% <ø> (-0.09%) ⬇️
netfx 70.15% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JRahnama JRahnama changed the title Add | Updating AKV dependencies Change | Updating AKV dependencies Jan 31, 2024
@JRahnama JRahnama merged commit 5e07b29 into dotnet:main Jan 31, 2024
148 checks passed
@JRahnama JRahnama deleted the akv-release branch March 8, 2024 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ErikEJ ErikEJ ErikEJ left review comments

@David-Engel David-Engel David-Engel approved these changes

@DavoudEshtehari DavoudEshtehari DavoudEshtehari approved these changes

@arellegue arellegue arellegue approved these changes

@H-Yeo H-Yeo Awaiting requested review from H-Yeo

Assignees
No one assigned
Labels
📦 AKV Provider Add-on: Azure Key Vault Provider related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@JRahnama @ErikEJ @David-Engel @DavoudEshtehari @arellegue