Merged SqlClientFactory between .NET Core and Framework #2369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the process, this implements CreateDataSourceEnumerator in .NET, linking it to the newly-added SqlDataSourceEnumerator class. In .NET Framework, it also needs to implement CreatePermission and the IServiceProvider interface.
Widened test coverage (slightly) to encompass the new CreateDataSourceEnumerator functionality. Changed FactoryMethodTest to account for the fact that this returns a singleton.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2369 +/- ##
==========================================
- Coverage 72.75% 72.69% -0.06%
==========================================
Files 313 311 -2
Lines 61718 61709 -9
==========================================
- Hits 44901 44862 -39
- Misses 16817 16847 +30
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
DavoudEshtehari
added
💡 Enhancement
kf-gonzalez
requested review from
David-Engel,
JRahnama,
DavoudEshtehari and
arellegue
DavoudEshtehari
approved these changes
May 9, 2024
src/Microsoft.Data.SqlClient/netcore/ref/Microsoft.Data.SqlClient.cs
Outdated
Show resolved
Hide resolved
David-Engel
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #1261. Also relates to #17 (specifically the last comment about SqlDataSourceEnumerator) and #2346.
This merges
SqlClientFactorybetween .NET Core and Framework. In the process, it also implementsCreateDataSourceEnumeratorin .NET, linking it to the newly-addedSqlDataSourceEnumeratorclass.In .NET Framework, SqlClientFactory also provides
CreatePermissionand implements theIServiceProviderinterface. I've left the latter in place to avoid a breaking change, although IServiceProvider is only used to accessSqlProviderServices(which is not part of the project.)